Working set references broken in setup

[felixdo]

Seems that 52912c5 inserted a new task with a manual copy/paste. Doing so is bad, because it breaks internal references, which then result in a broken .setup file. These are then detected in the setup archiver job on eclipse servers:

https://hudson.eclipse.org/oomph/job/setup-archiver/268197/console

You'll find these errors:

FAILED to load https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup
ERROR: Unresolved reference '//@setupTasks.13/@workingSets.4'. (https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup, 294, 131) 294 294 131
ERROR: Unresolved reference '//@setupTasks.13/@workingSets.1'. (https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup, 294, 131) 294 294 131
ERROR: Unresolved reference '//@setupTasks.13/@workingSets.3'. (https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup, 294, 131) 294 294 131
ERROR: Unresolved reference '//@setupTasks.13/@workingSets.4'. (https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup, 318, 67) 318 318 67

Meaning the catalog will not be updated with the newest version. You will also see these errors by just opening the .setup file inside eclipse with the 'Setup' editor.

You see that in the .setup file, elements reference each other by their reference + index. If you insert a new element just so, all the indices will shift around. That's what happened here. Had you used the setup editor this wouldn't have happened, because it keeps the references up-to-date when saving.

The gist is: Don't edit the file by hand unless you know what you're doing. Use the setup editor. And if you edit it by hand, at least check if it loads fine inside the Setup editor before committing. You could also check the above mentioned job for errors a while after pushing the file. If you need to change something again, feel free to ask me for review. Also the eclipse oomph forum will be helpful.