Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make highway _links same width? #1109

Closed
daganzdaanda opened this issue Nov 1, 2014 · 20 comments · Fixed by #3570
Closed

Make highway _links same width? #1109

daganzdaanda opened this issue Nov 1, 2014 · 20 comments · Fixed by #3570

Comments

@daganzdaanda
Copy link

Motorway_link seems to be the only "highway_link" that has it's own width.
Where a motorway_link meets a primary_link or secondary_link, the lower ranked road is wider.
http://www.openstreetmap.org/node/268585122
http://www.openstreetmap.org/node/412383929

Would a single width for all possible highway_links be a good idea?

@Circeus
Copy link

Circeus commented Nov 6, 2014

I could have sworn primary_link used to be thinner... I agree they should all have a common width.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Nov 30, 2014
@matthijsmelissen
Copy link
Collaborator

Why should links be the same width? I think thinner links make complex junctions, such as this one easier to interpret.

@matkoniecz
Copy link
Contributor

I think thinner links make complex junctions, such as this one easier to interpret.

@math1985 Yes, and @daganzdaanda wants to apply the same to _primary and _secondary links. Compare

line-width: @motorway-width-z12 - 2 * @casing-width-z12;
and
line-width: @trunk-width-z12 - 2 * @casing-width-z12;

@matthijsmelissen
Copy link
Collaborator

Sorry, misread the request.

I think making all highway links thinner would be nice visually, but comes with quite heavy performance penalties (basically all highway rules need to be duplicated).

@aaronstar
Copy link

I support this notion.

@jojo4u
Copy link

jojo4u commented Feb 12, 2015

Another example of secondary_link showing up on the other end of motorway_link: http://www.openstreetmap.org/way/143164004

@matthijsmelissen
Copy link
Collaborator

Issue is still open in new road style.

@matthijsmelissen
Copy link
Collaborator

@matkoniecz Do you have any opinion on this issue?

@matkoniecz
Copy link
Contributor

@math1985 Both avoiding code complexity and narrower _links are desirable. I would need to check how badly it would increase amount of code before I will have opinion whatever it is worth the cost.

@newnumber2
Copy link

@matkoniecz how would making trunk_link, primary_link, etc. narrower require writing a lot of code?

@Roadsguy
Copy link

Roadsguy commented Jun 9, 2017

It seems kinda silly for ramps from a trunk road to be so much thicker than ramps from a motorway. Consider the interchange complex with I-95, I-895, US 40, and Moravia Road in Baltimore, MD. There are three ramps from the trunk Moravia Rd. down to surface US 40. They are built to identical standards as the motorway_link ramps, yet current rendering makes them stick out too much.

@jojo4u
Copy link

jojo4u commented Jun 17, 2017

@Roadsguy please provide a link or better a screenshot.

@Roadsguy
Copy link

Here is a link to the area I mentioned. As you can see, some of the ramps in this interchange complex are mapped with trunk_link, which makes them thicker on the map than the motorway_link ramps. However, there's no difference in the physical design of these ramps; it's all arbitrary because that's how trunk_links are set to render. Ideally they would render as thin as motorway_link.

primary_link and below don't seem to apply to ramps as often and might not need to be thinner as much as trunk_links do. However, in America (with surface expressways) and the UK/Europe (with trunk roads), trunk_links serving as exit ramps equivalent to motorway_link are very common.

@newnumber2
Copy link

In my opinion ALL "links" should be the same width, both in the renderer and in every editor, and should be the width of the current "motorway links". This seems like an awful inconsistency and should be fixed, the sooner the better. It's especially bad where a trunk, primary, secondary or tertiary link has a junction with a motorway link. I've seen this so many times.

@jengelh
Copy link

jengelh commented Sep 5, 2018

Discrepancy (51.55647/9.88576, z17); shows motorway_link, trunk_link and secondary_link:
discrepancy

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 6, 2018

Closed by #3374 - we just left tertiary links different to not mix them with smaller roads.

@kocio-pl kocio-pl closed this as completed Sep 6, 2018
@LucFreitas
Copy link

Leaving different tertiary links causes oddities in connections to higher-order tertiary links.

1

@kocio-pl
Copy link
Collaborator

Thanks for reporting. I'm aware that there are places like this, there is no way to avoid problems with different width of roads in general.

@jeisenbe
Copy link
Collaborator

I would like to make the tertiary links the same width as secondary links.

I noticed that there is no width for tertiary-links while working on the new code for highway=construction.

I think there was a concern in #3374 that tertiary links would then look similar to highway=unclassified and =residential, because tertiary is currently rendered in white, as are these other minor roads.

However, I don't see this as a problem. Tertiary links are usually very short slip roads joining a tertiary road to a small road (eg highway=unclassified). Having them thinner will make the map more readable.

@Roadsguy
Copy link

Roadsguy commented Dec 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.