Skip to content

Commit

Permalink
Improve legibility of shop names.
Browse files Browse the repository at this point in the history 
Increase the size of the text to make it readable, and increase
the halo to remove aliasing artefacts. The touch of translucency
reduces the attention-grabbing white above darker backgrounds like
buildings.

Other pois should get the same treatment, but we really need a
test-suite to handle the text-dy issue.
  • Loading branch information
@gravitystorm
gravitystorm committed Nov 14, 2014
1 parent 37a928e commit 5c630b3
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions amenity-points.mss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1386,11 +1386,12 @@
[feature = 'shop_other']{
[zoom >= 17] {
text-name: "[name]";
text-size: 8;
text-dy: 10;
text-size: 10;
text-dy: 12;
text-fill: #939;
text-face-name: @book-fonts;
text-halo-radius: 1;
text-halo-radius: 1.5;
text-halo-fill: rgba(255, 255, 255, 0.8);
text-wrap-width: @standard-wrap-width;
text-placement: interior;
}
Expand All @@ -1400,11 +1401,12 @@
[feature = 'shop_department_store'] {
[zoom >= 16] {
text-name: "[name]";
text-size: 9;
text-dy: 11;
text-size: 10;
text-dy: 12;
text-fill: #939;
text-face-name: @book-fonts;
text-halo-radius: 1;
text-halo-radius: 1.5;
text-halo-fill: rgba(255, 255, 255, 0.8);
text-wrap-width: @standard-wrap-width;
text-placement: interior;
}
Expand Down

2 comments on commit 5c630b3

@matthijsmelissen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that @mkoniecz was also working on this (this is about bold versus book, but it is meant to solve the same problem). He decided to postpone the issue as the change of the building colors interacts with the minimal required font size for legibility.

@matkoniecz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other pois should get the same treatment, but we really need a
test-suite to handle the text-dy issue.

I am working on this issue (though my program is hilariously slow - as Ruby-mapnik is currently broken for me* I load data into database and render using Tilemill)

* mapnik/Ruby-Mapnik#48 mapnik/Ruby-Mapnik#47

Please sign in to comment.