Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tertiary-link width, same as other links #3570

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Dec 14, 2018

Fixes #1109
(This issue is currently closed, but tertiary_link was not added)

Changes proposed in this pull request:

  • Render highway=tertiary_link thinner than highway_tertiary (generally the same width as secondary_link)

Explanation:
Leaving different tertiary links causes oddities in connections to higher-order tertiary links, eg

Tertiary_link is used over 150k times and is mentioned in the highway link documentation, and it is currently rendered, but at the same width as highway=tertiary. This makes the tertiary links significantly wider than motorway, trunk, primary and secondary links.

Previously this was not fixed, because tertiary has been rendered in white, the same as minor roads such as highway=unclassified and highway=residential, and the thinner tertiary links will be similar in appearance to these roads. However, there is currently a plan to change the highway colors, which will render tertiary in yellow. Even if this is not implemented, it is better to render the link roads consistently.

Test rendering with links to the example places:

Tertiary links in Wales, Great Britain

  1. Before
    1-tertiary-master

After
1-tertiary-after

  1. Before
    2-tertiary-master

After
2-tertiary-after

  1. Before
    3-tertiary-master

After
3-tertiary-after

@kocio-pl
Copy link
Collaborator

This was skipped in #3374 to not mix with smaller roads, because they are all white.

Example 3 shows that probably tagging is inconsistent, but it can look pretty bad if all such connectors are tagged as links.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Dec 14, 2018 via email

@kocio-pl
Copy link
Collaborator

I am not sure which tagging is proper, but thinner rendering looks bad to me.

@Adamant36
Copy link
Contributor

For me it looks better in the first and third (although kind of wierd in the third) examples, but not in the second example.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Dec 14, 2018 via email

@Adamant36
Copy link
Contributor

I could see why there would be a debate about it. Misstaging seems possible. As it seems weird. As you say though, it looks good branching off the main road. So I dont know.

@jeisenbe
Copy link
Collaborator Author

I asked about this issue on the tagging mailing list, and a couple of people responded. They agreed that a road that splits to enter a roundabout, or at a Y-junction, should not be tagged as a highway=*_link. So examples 2 and 3 above are mistagged, by this standard.

https://lists.openstreetmap.org/pipermail/tagging/2018-December/041500.html

This is good to know, because all of the non-motorway links (trunk thru secondary) can also be affected by this rendering issue.

@kocio-pl
Copy link
Collaborator

Example 1 looks better with new rendering, so I would upvote it now.

@kocio-pl kocio-pl merged commit 06a7d12 into gravitystorm:master Dec 27, 2018
@kocio-pl
Copy link
Collaborator

I believe it's good to try this for catching tagging problems, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make highway _links same width?
3 participants