-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tertiary-link width, same as other links #3570
Conversation
This was skipped in #3374 to not mix with smaller roads, because they are all white. Example 3 shows that probably tagging is inconsistent, but it can look pretty bad if all such connectors are tagged as links. |
Re example 3.
Do you mean it looks bad because it is mistagged? Or that it would look bad
if properly tagged?
…On Fri, Dec 14, 2018 at 8:49 PM kocio-pl ***@***.***> wrote:
This was skipped in #3374
<#3374> to not
mix with smaller roads, because they are all white.
Example 3 shows that probably tagging is inconsistent, but it can look
pretty bad if all such connectors are tagged as links.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3570 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshL6wJqXd3SbWTbUV6oiKKNM5YAdFks5u45BIgaJpZM4ZTXRb>
.
|
I am not sure which tagging is proper, but thinner rendering looks bad to me. |
For me it looks better in the first and third (although kind of wierd in the third) examples, but not in the second example. |
Hmm, the wiki page / talk page suggests that there is some debate about
whether this sort of y-junctions and entrances to traffic circles should be
tagged as links, so perhaps this is a tagging error.
See https://wiki.openstreetmap.org/wiki/Talk:Highway_link ,
"Y Junctions should NOT be classified as links."
and
https://wiki.openstreetmap.org/wiki/Highway_link
and
https://wiki.openstreetmap.org/wiki/Link_roads_between_different_highways_types
For me it looks better in the first and third (although kind of wierd in
the third) examples, but not in the second example.
I think it looks better when the link is branching off from the main
tertiary road, but it looks odd when a highway=tertiary splits into two
highway=tertiary_link - and perhaps this is not the best way to tag.
|
I could see why there would be a debate about it. Misstaging seems possible. As it seems weird. As you say though, it looks good branching off the main road. So I dont know. |
I asked about this issue on the tagging mailing list, and a couple of people responded. They agreed that a road that splits to enter a roundabout, or at a Y-junction, should not be tagged as a highway=*_link. So examples 2 and 3 above are mistagged, by this standard. https://lists.openstreetmap.org/pipermail/tagging/2018-December/041500.html This is good to know, because all of the non-motorway links (trunk thru secondary) can also be affected by this rendering issue. |
Example 1 looks better with new rendering, so I would upvote it now. |
I believe it's good to try this for catching tagging problems, thanks! |
Fixes #1109
(This issue is currently closed, but tertiary_link was not added)
Changes proposed in this pull request:
Explanation:
Leaving different tertiary links causes oddities in connections to higher-order tertiary links, eg
Tertiary_link is used over 150k times and is mentioned in the highway link documentation, and it is currently rendered, but at the same width as highway=tertiary. This makes the tertiary links significantly wider than motorway, trunk, primary and secondary links.
Previously this was not fixed, because tertiary has been rendered in white, the same as minor roads such as highway=unclassified and highway=residential, and the thinner tertiary links will be similar in appearance to these roads. However, there is currently a plan to change the highway colors, which will render tertiary in yellow. Even if this is not implemented, it is better to render the link roads consistently.
Test rendering with links to the example places:
Tertiary links in Wales, Great Britain
After
After
After