Fix Flaky Retry Tests #9516
Merged
Fix Flaky Retry Tests #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/flaky_tests
branch
5 times, most recently
from
05cdc1a to
0326c13
Compare
rosstimothy
force-pushed
the
tross/flaky_tests
branch
4 times, most recently
from
fa91777 to
a2c3efe
Compare
Closed
zmb3
approved these changes
Jan 4, 2022
espadolini
approved these changes
Jan 5, 2022
rosstimothy
force-pushed
the
tross/flaky_tests
branch
from
a2c3efe to
0f68db4
Compare
Addresses issues causing failures in TestCache_Backoff, TestTeleportProcess_reconnectToAuth and TestResourceWatcher_Backoff. By utilizing FakeClock.BlockUntil tests ensure that the clock will not be advanced until retry.After has been called.
rosstimothy
force-pushed
the
tross/flaky_tests
branch
from
e994a90 to
145d1d0
Compare
rosstimothy
added a commit
that referenced
this pull request
Jan 11, 2022
rosstimothy
added a commit
that referenced
this pull request
Jan 11, 2022
rosstimothy
added a commit
that referenced
this pull request
Jan 20, 2022
Fix flaky unit tests Addresses issues causing failures in TestCache_Backoff, TestTeleportProcess_reconnectToAuth and TestResourceWatcher_Backoff. By utilizing FakeClock.BlockUntil tests ensure that the clock will not be advanced until retry.After has been called. Move retry duration channels to config in order to allow them to be buffered by tests.
rosstimothy
added a commit
that referenced
this pull request
Jan 20, 2022
Fix flaky unit tests Addresses issues causing failures in TestCache_Backoff, TestTeleportProcess_reconnectToAuth and TestResourceWatcher_Backoff. By utilizing FakeClock.BlockUntil tests ensure that the clock will not be advanced until retry.After has been called. Move retry duration channels to config in order to allow them to be buffered by tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests Addressed in this PR:
github.com/gravitational/teleport/lib/service.TestTeleportProcess_reconnectToAuthgithub.com/gravitational/teleport/lib/service.TestResourceWatcher_Backoffgithub.com/gravitational/teleport/lib/cache.TestCache_BackoffThe Backoff/Reconnect tests now utilize
FakeClock.BlockUntilto prevent advancing the clock until the underlyingutils.Retryhas calledAfter.