Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #9133 to branch/v7 #9874

Merged
merged 6 commits into from
Jan 27, 2022
Merged

backport #9133 to branch/v7 #9874

merged 6 commits into from
Jan 27, 2022

Conversation

rosstimothy
Copy link
Contributor

Backport of #9133 and flaky test fixes from #9516

rosstimothy and others added 5 commits January 20, 2022 16:01
@rosstimothy
Add jitter and backoff to prevent thundering herd on auth (#9133)
8359140 
Move cache and resourceWatcher watchers from a 10s retry to a jittered backoff retry up to ~1min. Replace the
reconnectToAuthService interval with a retry to add jitter and backoff there as well for when a node restarts due to
changes introduced in #8102.

Fixes #6889.
@rosstimothy
cache_test
2f1acc1
@rosstimothy
Fix Flaky Retry Tests (#9516)
62330ac 
Fix flaky unit tests
Addresses issues causing failures in TestCache_Backoff, TestTeleportProcess_reconnectToAuth
and TestResourceWatcher_Backoff. By utilizing FakeClock.BlockUntil tests ensure that the clock
will not be advanced until retry.After has been called. Move retry duration channels to config in order to allow them to be buffered by tests.
@rosstimothy
fix build
dc4f123
@rosstimothy
fix stale watcher test
a7f612f
@rosstimothy rosstimothy marked this pull request as ready for review January 20, 2022 22:33
@rosstimothy
Copy link
Contributor Author

friendly ping @smallinsky @xacrimon

@rosstimothy rosstimothy merged commit d8a52bc into branch/v7 Jan 27, 2022
@rosstimothy rosstimothy deleted the tross/v7/auth_restart_jitter branch January 27, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallinsky smallinsky smallinsky approved these changes

@xacrimon xacrimon xacrimon approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @xacrimon @smallinsky