Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #9133 to branch/v8 #9867

Merged
merged 5 commits into from
Jan 27, 2022
Merged

backport #9133 to branch/v8 #9867

merged 5 commits into from
Jan 27, 2022

Conversation

rosstimothy
Copy link
Contributor

Backport of #9133 and flaky test fixes from #9516

@rosstimothy
Add jitter and backoff to prevent thundering herd on auth (#9133)
787bd8c 
Move cache and resourceWatcher watchers from a 10s retry to a jittered backoff retry up to ~1min. Replace the
reconnectToAuthService interval with a retry to add jitter and backoff there as well for when a node restarts due to
changes introduced in #8102.

Fixes #6889.
@rosstimothy
Fix Flaky Retry Tests (#9516)
21bbf16 
Fix flaky unit tests
Addresses issues causing failures in TestCache_Backoff, TestTeleportProcess_reconnectToAuth
and TestResourceWatcher_Backoff. By utilizing FakeClock.BlockUntil tests ensure that the clock
will not be advanced until retry.After has been called. Move retry duration channels to config in order to allow them to be buffered by tests.
@github-actions github-actions bot requested review from jimbishopp and r0mant January 20, 2022 20:50
@rosstimothy
Copy link
Contributor Author

friendly ping @r0mant

@rosstimothy rosstimothy merged commit 7f62325 into branch/v8 Jan 27, 2022
@rosstimothy rosstimothy deleted the tross/v8/auth_restart_jitter branch January 27, 2022 20:00
@webvictim webvictim mentioned this pull request Mar 4, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russjones russjones russjones approved these changes

@jimbishopp jimbishopp jimbishopp approved these changes

@r0mant r0mant Awaiting requested review from r0mant

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @jimbishopp @russjones