add bot edit-role flow #37828
Merged
add bot edit-role flow #37828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellescripts
force-pushed
the
michelle/edit-bot
branch
from
5a75c01 to
2b0b610
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
michellescripts
requested review from
ryanclark,
strideynet and
kimlisa
and removed request for
r0mant and
jimbishopp
strideynet
reviewed
Feb 7, 2024
| botName := "test-bot-edit" | ||
| _, err := pack.clt.PostJSON(ctx, endpoint, CreateBotRequest{ | ||
| BotName: botName, | ||
| Roles: []string{""}, |
There was a problem hiding this comment.
Welp - I'm fairly sure it shouldn't be possible to create a bot with a role which is just an empty string... I'll add it to my to-do list. I'd avoid the test depending on this being possible as it'll break when I fix it.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
michellescripts
added
the
no-changelog
ryanclark
approved these changes
Feb 8, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
michellescripts
force-pushed
the
michelle/edit-bot
branch
2 times, most recently
from
59f49db to
929888f
Compare
michellescripts
force-pushed
the
michelle/edit-bot
branch
from
929888f to
fb5d93f
Compare
michellescripts
added a commit
that referenced
this pull request
Feb 12, 2024
* add bot edit-role flow * only send masked/updated fields
michellescripts
added a commit
that referenced
this pull request
Feb 13, 2024
* add bot edit-role flow * only send masked/updated fields
michellescripts
added a commit
that referenced
this pull request
Feb 16, 2024
* add bot edit-role flow * only send masked/updated fields
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Add endpoint to get bots by name (#37412) * Add endpoint to get bots by name * Lint * Fix test method's name Co-authored-by: Noah Stride <[email protected]> --------- Co-authored-by: Noah Stride <[email protected]> * Backend supporting changes for Bot creation flow (#37348) * Add bot ui labels and github join token * Use strings.HasPrefix instead of includes * Add `ssh` to label * Add bot join token endpoint * Lint * Fix comment typo Co-authored-by: Bartosz Leper <[email protected]> * Fix comment typo Co-authored-by: Bartosz Leper <[email protected]> * Improve webUIFlowLabelKey comment --------- Co-authored-by: Bartosz Leper <[email protected]> * add bots UI, disabled (#36845) - in original data table view * Add Bot + GitHub Actions SSH UI Flow (#37443) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <[email protected]> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Update copy and minor style change --------- Co-authored-by: Michelle Bergquist <[email protected]> Co-authored-by: Noah Stride <[email protected]> * add bot edit-role flow (#37828) * add bot edit-role flow * only send masked/updated fields * Add GitHub Actions bot view (#37852) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <[email protected]> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Add bot type by label * Add bot view... * Show view gh actions yaml only for gh bots * Use existing pattern for operations * Add story and missing license * Fix typos Co-authored-by: Michelle Bergquist <[email protected]> --------- Co-authored-by: Michelle Bergquist <[email protected]> Co-authored-by: Noah Stride <[email protected]> Co-authored-by: Michelle Bergquist <[email protected]> * Add buttons to download and copy to clipboard content to `TextEditor` (#37333) * Add editor buttons * Set icon size * Move downloadObject to OSS * remove unused test-id * Use values from theme * Fix buttons positioning * Convert jsx files to tsx * Use const instead of var * Add z-index to buttons * Add license * Improvements to Bot resource (additional validation and label propagation) (#38013) * PRevent creating bots with an empty string role * Propagate labels to Bot user and vice versa * Extract slice declaration for nonPropagatedLabels * Fixed web tests relying on empty string roles * Use "set" instead of slice for nonPropagatedLabels * Make testing of empty string handling more thorough * add role assertions to create * Appease linter as to want/got order --------- Co-authored-by: Michelle Bergquist <[email protected]> * Add bot permissions and turn on feature (#37943) * Fix makeBot labels (#38176) --------- Co-authored-by: matheus <[email protected]> Co-authored-by: Noah Stride <[email protected]> Co-authored-by: Bartosz Leper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to edit roles associated with a bot.
Screen.Recording.2024-02-06.at.1.21.13.PM.mov
supports #34260