[v15] bot list and create UI #38122
Merged
[v15] bot list and create UI #38122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellescripts
force-pushed
the
michelle/v15-machine-id-list
branch
2 times, most recently
from
f99618d to
4840842
Compare
|
/excludeflake * |
michellescripts
force-pushed
the
michelle/v15-machine-id-list
branch
from
7d3d231 to
3b5976a
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
@michellescripts - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
approved these changes
Feb 13, 2024
ryanclark
approved these changes
Feb 14, 2024
zmb3
approved these changes
Feb 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
michellescripts
force-pushed
the
michelle/v15-machine-id-list
branch
3 times, most recently
from
ecb2b42 to
c3ae018
Compare
* Add endpoint to get bots by name * Lint * Fix test method's name Co-authored-by: Noah Stride <[email protected]> --------- Co-authored-by: Noah Stride <[email protected]>
* Add bot ui labels and github join token * Use strings.HasPrefix instead of includes * Add `ssh` to label * Add bot join token endpoint * Lint * Fix comment typo Co-authored-by: Bartosz Leper <[email protected]> * Fix comment typo Co-authored-by: Bartosz Leper <[email protected]> * Improve webUIFlowLabelKey comment --------- Co-authored-by: Bartosz Leper <[email protected]>
- in original data table view
* add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <[email protected]> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Update copy and minor style change --------- Co-authored-by: Michelle Bergquist <[email protected]> Co-authored-by: Noah Stride <[email protected]>
* add bot edit-role flow * only send masked/updated fields
* add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <[email protected]> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Add bot type by label * Add bot view... * Show view gh actions yaml only for gh bots * Use existing pattern for operations * Add story and missing license * Fix typos Co-authored-by: Michelle Bergquist <[email protected]> --------- Co-authored-by: Michelle Bergquist <[email protected]> Co-authored-by: Noah Stride <[email protected]> Co-authored-by: Michelle Bergquist <[email protected]>
…#37333) * Add editor buttons * Set icon size * Move downloadObject to OSS * remove unused test-id * Use values from theme * Fix buttons positioning * Convert jsx files to tsx * Use const instead of var * Add z-index to buttons * Add license
…tion) (#38013) * PRevent creating bots with an empty string role * Propagate labels to Bot user and vice versa * Extract slice declaration for nonPropagatedLabels * Fixed web tests relying on empty string roles * Use "set" instead of slice for nonPropagatedLabels * Make testing of empty string handling more thorough * add role assertions to create * Appease linter as to want/got order --------- Co-authored-by: Michelle Bergquist <[email protected]>
michellescripts
force-pushed
the
michelle/v15-machine-id-list
branch
from
c3ae018 to
76912a2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This was referenced Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports new Machine ID UX to v15.
e-sibling: https://github.com/gravitational/teleport.e/pull/3432
cc @mcbattirola
cc @strideynet
Supports https://github.com/gravitational/cloud/issues/6664
changelog: Add the ability to view and manage Machine ID bots from the UI