Backport of #1188 "Serve staticfiles in the webapp if whitenoise is installed" to 0.9.x #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstalled" to 0.9.x This avoids the collectstatic step & apache configuration. It's probably slightly less optimal than serving files with apache/nginx but much easier to start with. Whitenoise is compatible with Django 1.4 and above, but before version 2.0.2 it was compatible only with python 2.7, so in this version safecheck is included. Tested with synthesize and manual whitenoise installation, but please check more.
Proper Whitenoise detection backpoted from master #1296
|
This looks ok to me, @brutasse any opinions? |
|
@obfuscurity LGTM, but I haven't touched 0.9.x in ages :) |
|
@deniszh Are the benefits worth the added complexity to 0.9.x? If we can't enforce a minimum version of whitenoise (because of python/django dependencies and conflicts) in setup.py, I wonder if many users will know to take advantage of it. |
|
Bah, humbug. |
obfuscurity
added a commit
that referenced
this pull request
Sep 27, 2015
Backport of #1188 "Serve staticfiles in the webapp if whitenoise is installed" to 0.9.x
|
Latest whitenoise supports 2.6, it's just more, like, precaution. IMO will help in some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the collectstatic step & apache configuration. It's probably slightly less optimal than serving files with apache/nginx but much easier to start with.
Whitenoise is compatible with Django 1.4 and above, but before version 2.0.2 it was compatible only with python 2.7, so in this version safecheck is included.
Tested with synthesize and manual whitenoise installation, but please check more.
Rebase of #1209