-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of #1188 "Serve staticfiles in the webapp if whitenoise is installed" to 0.9.x #1209
Conversation
@brutasse , @obfuscurity - please check, thanks! |
From a quick read it looks ok, but I don't have the bandwidth to test it. |
deniszh: how do I go about checking this? |
@esc: Very good question, indeed. I just found that I do not know. Synthesize working properly on Django 1.4-1.7 and there's no need to setup /static alias at all.... 😕 |
@deniszh you're welcome 😉 |
@obfuscurity: yep, that's good in general, but not in that specific case. |
@deniszh If you're trying to upgrade to Django 1.8, it's no longer Synthesize. Synthesize uses requirements.txt, which is frozen to 1.4. |
According to #1252 (comment) and whitenoise docs it doesn't work with python 2.6 and 0.9.13 must working with it. |
Add that change and squashed commits. |
This looks reasonable to me, although I'm not the biggest fan of skipping using a web server like Apache or nginx. Personally, it shouldn't be a warning in the check deps script, perhaps just an INFO message? |
@SEJeff - will change it, thanks! |
Is anyone has idea why Travis is b0rking on that change for all Django's except 1.8 ? |
Probably a similar issue to sous-chefs/graphite#227 |
…nstalled". This avoids the collectstatic step & apache configuration. It's probably slightly less optimal than serving files with apache/nginx but much easier to start with. Whitenoise until recent versions (>2.0.2) was compatible with Django 1.4 and above but requires python 2.7
This fixes #1142.
Ah, screw it. Will make another commit, this one is too distant from 0.9.x |
This avoids the collectstatic step & apache configuration. It's probably slightly less optimal than serving files with apache/nginx but much easier to start with.
Whitenoise is compatible with Django 1.4 and above.
Tested with synthesize and manual whitenoise installation, but please check more.