Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source/Dest properties #24

Open
lmeyerov opened this issue Dec 13, 2021 · 3 comments
Open

Source/Dest properties #24

lmeyerov opened this issue Dec 13, 2021 · 3 comments
Assignees
@dm-p
Labels
bug Something isn't working enhancement New feature or request P3

Comments

@lmeyerov
Copy link
Contributor

lmeyerov commented Dec 13, 2021 •
edited
Loading

Filling in src/dst properties does not actually make them appear in the UI
@lmeyerov lmeyerov added the enhancement New feature or request label Dec 13, 2021
@lmeyerov lmeyerov added P3 bug Something isn't working labels May 10, 2022
@lmeyerov
Copy link
Contributor Author

Requires enabling nodeFile creation/upload

@lmeyerov lmeyerov mentioned this issue May 24, 2022
Open
4 tasks
@dess890
Copy link
Contributor

dess890 commented Jun 10, 2022

line 33 on capabilities.json, no spaces
"name": "DestinationProperty",

line 166 in visual.ts needs to recplicated but for the destination property.
const edgePropertyMetadatas = view.metadata.columns.filter((c) => c.roles.EdgeProperty);

@lmeyerov lmeyerov assigned dm-p and unassigned dess890 Jun 17, 2022
@lmeyerov lmeyerov removed the blocked label Jun 17, 2022
@lmeyerov
Copy link
Contributor Author

Need to also:

  • create a nodes GraphistryFile
  • detect whether changed to gate whether needing to reupload vs reuse
  • include in what is passed to GraphistryDataset, including memoization decision

dm-p added a commit that referenced this issue Jun 22, 2022
@dm-p
fix (multiple files): renamed Source & Destination data roles (#24)
33d7bd9 
- Power BI seems to enforce drilldown (even though not explicitly enabled in capabilities) if a data role is named `Source`. MS tend to have some reserved names with special behaviour for properties; looks like this is potentially the case for data roles also.
- To ensure that multiple fields project into the data view mapping, these have been renamed to `SourceNode` and `DestinationNode` respectively (for consistency purposes)
- This has no effect on displayed field names in the Visualizations pane, but will mean that when the visual is next used, **the author (or developer) will need to re-apply their intended fields to these roles** via the UI (due to the internal name changing).
- The dependent login in `Loader.tsx` has been updated to match the new names, to ensure that the UX makes sense for the author.
- The mapping logic in `visual.ts` has been updated to match the new internal  names, but the logic to work with multiple fields for the request is still pending and should be addressed in a subsequent commit.
dm-p added a commit that referenced this issue Jun 30, 2022
@dm-p
Flatten column names and values with a comma-delimiter (#24)
b3dc6c5 
Applies to both Source and Destination node data roles.

e.g. if `FirstName` + `LastName` columns are supplied, this will name the field as `FirstName,LastName'

Values submitted to the request are then similarly flattened, e.g.:

`["Daniel,Marsh-Patrick", "Desirree,Adegunle"]`

This pattern will consolidate and delimit a smany columns as are supplied to each data role.
dm-p added a commit that referenced this issue Jun 30, 2022
@dm-p
Resolving linting issues (#24)
f55ee5e
lmeyerov added a commit that referenced this issue Jul 2, 2022
@lmeyerov
Merge pull request #73 from graphistry/dm-p
419e8d1 
Flatten column names and values with a comma-delimiter (#24)
dm-p added a commit that referenced this issue Aug 19, 2022
@dm-p
Adding nodeFile for src/dest nodes and properties (#24)
e605fa0 
- Source/destination data is inspected, to identify candidates that should be excluded from node list.
- Exclusion is marked rather than done upstream so that the data can be reused for edges without additional manipulation
- Rules are currently FIFO wrt. source vs destination , so if destination nodes contains an ID that exists in sources, the source and its properties will win and the destination will be excluded.
- Edge case handling for if all source or destination nodes are excluded, resulting in zero-length arrays (which cause rendering fails server-side).
- Extraction has been tweaked from prior commit, with some more refactoring to try and DRY-up some of the reusable bits.
dm-p added a commit that referenced this issue Aug 31, 2022
@dm-p
Re-worked nodeFile entries to include distinct values (#24, #82)
d3e4aed 
- Looks for unique values across source and destination data roles, and ensures that only distinct entries are included in the nodeFile
- For source and destination properties, the row matching the first discovered index is used for values, to prevent property arrays potentially being ragged and causing server issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dm-p dm-p

Labels
bug Something isn't working enhancement New feature or request P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmeyerov @dm-p @dess890