Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/src properies arent working? #82

Open
dess890 opened this issue Aug 29, 2022 · 2 comments
Open

node/src properies arent working? #82

dess890 opened this issue Aug 29, 2022 · 2 comments
Assignees

Comments

@dess890
Copy link
Contributor

dess890 commented Aug 29, 2022

anything added to the src/node properties results in 0 nodes and 0 edges?

  • i do see where memoization is occuring in console
  • viz works up until you add anything regarding src/node properties
  • Starting iframe protocol listen flow: Message has origin returning null?

Screen Shot 2022-08-29 at 12 09 55 PM

dm-p added a commit that referenced this issue Aug 31, 2022
- Looks for unique values across source and destination data roles, and ensures that only distinct entries are included in the nodeFile
- For source and destination properties, the row matching the first discovered index is used for values, to prevent property arrays potentially being ragged and causing server issues
@dm-p
Copy link
Contributor

dm-p commented Aug 31, 2022

Commit d3e4aed re-works the nodeFile entries to work better here. This will resolve both issues discovered during reproducing this on my machine:

  • If the source or destination data roles contain many repeating values (which will be common for Power BI), these are resolved to the distinct entries across both
  • For unique entries, the first discovered location in each array is stored, and then used for subsequent lookup of source and destination properties from the dataset. This avoids issues where the combination of properties results in more rows for each combination of source and destination (which would result in arrays of a ragged length for properties)

@dess890, hopefully your test should now look similar to the following if you update your branch:

image

@lmeyerov
Copy link
Contributor

lmeyerov commented Nov 2, 2022

@dess890 can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants