Flatten column names and values with a comma-delimiter (#24) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies to both Source and Destination node data roles. e.g. if `FirstName` + `LastName` columns are supplied, this will name the field as `FirstName,LastName' Values submitted to the request are then similarly flattened, e.g.: `["Daniel,Marsh-Patrick", "Desirree,Adegunle"]` This pattern will consolidate and delimit a smany columns as are supplied to each data role.
lmeyerov
reviewed
Jul 1, 2022
| @@ -209,7 +212,8 @@ export class Visual implements IVisual { | |||
| ); | |||
| return false; | |||
| } | |||
| for (let i = 0; i < this.prevValues[colName].length; i++) { // eslint-disable-line | |||
| for (let i = 0; i < this.prevValues[colName].length; i += 1) { | |||
| // eslint-disable-line | |||
There was a problem hiding this comment.
unintentional linebreak? or lint no longer needed?
|
@dess890 can you try building and confirming generates graph topology + edge src/dest/properities as expected? |
dess890
approved these changes
Jul 2, 2022
dess890
approved these changes
Jul 2, 2022
|
Great, merging! @dm-p feel free to continue or delete branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to both Source and Destination node data roles.
e.g. if
FirstName+LastNamecolumns are supplied, this will name the field as `FirstName,LastName'Values submitted to the request are then similarly flattened, e.g.:
["Daniel,Marsh-Patrick", "Desirree,Adegunle"]This pattern will consolidate and delimit a smany columns as are supplied to each data role.