Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Tap #1251

Closed
5 tasks done
Tracked by #428
ankur22 opened this issue Mar 21, 2024 · 1 comment
Closed
5 tasks done
Tracked by #428

Async Tap #1251

ankur22 opened this issue Mar 21, 2024 · 1 comment
Assignees
@inancgumus
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Mar 21, 2024 •
edited by inancgumus
Loading

We want to convert the touchscreen.tap API from being synchronous to async (promisify). This will include:

  1. De-gojafying the tap method in the common package.
  2. Move the goja code into the mapping layer.
  3. Wrap the call to touchscreen.tap from the mapping layer in a promise.

Related Issue: #428

Tasks
Preview Give feedback
  1. De-sobekify the Tap methods and remove panics #1265
    refactor stability
    inancgumus
  2. Make Tap async #1268
    async
    inancgumus
  3. Update tap to async for k6 browser module k6-DefinitelyTyped#36
    browser
    inancgumus
  4. Update browser tap to async k6-docs#1564
    Area: browser
    inancgumus
  5. Release notes: Browser async Tap k6#3723
    area: browser docs
    inancgumus
@ankur22 ankur22 added the breaking PRs that need to be mentioned in the breaking changes section of the release notes label Mar 21, 2024
@inancgumus inancgumus self-assigned this Apr 15, 2024
@inancgumus inancgumus mentioned this issue Apr 17, 2024
Merged
3 tasks
@inancgumus inancgumus added the async supports async (promises) label Apr 18, 2024
This was referenced Apr 18, 2024
Merged
Merged
This was referenced Apr 26, 2024
Merged
Merged
Merged
Closed
@inancgumus
Copy link
Member

The doc updates will continue in #1293.

@inancgumus inancgumus changed the title Convert Touchscreen.tap() to async Async Tap May 2, 2024
@ankur22 ankur22 mentioned this issue May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inancgumus inancgumus

Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inancgumus @ankur22