Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Tap #1288

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Async Tap #1288

merged 4 commits into from
Apr 26, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Apr 26, 2024 •
edited
Loading

@inancgumus inancgumus requested a review from ankur22 April 26, 2024 13:11
ankur22
ankur22 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit d7f338b into main Apr 26, 2024
17 checks passed
@inancgumus inancgumus deleted the main-async branch April 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22