Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser Tap methods from sync to async #1572

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update browser Tap methods from sync to async #1572

merged 1 commit into from
Apr 29, 2024

Conversation

inancgumus
Copy link
Member

What?

Update browser Tap method docs to async.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/xk6-browser#1251

@inancgumus inancgumus merged commit d3c265d into main Apr 29, 2024
4 checks passed
@inancgumus inancgumus deleted the main-browser-async branch April 29, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitortsergent heitortsergent Awaiting requested review from heitortsergent heitortsergent is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inancgumus