Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser tap to async #1564

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Apr 24, 2024

What?

Updates the browser module's Tap methods to async.

We're putting this change into the main-browser-async branch because we're still discussing our options for migrating the K6 browser from sync to async.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

Updates grafana/xk6-browser#1251

@inancgumus inancgumus self-assigned this Apr 24, 2024
@inancgumus inancgumus added the Area: browser The browser module label Apr 24, 2024
@inancgumus inancgumus changed the base branch from main to main-browser-async April 24, 2024 10:49
@inancgumus inancgumus requested a review from ankur22 April 24, 2024 10:49
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I think it's worth also adding the tap docs for the touchscreen class. I've been adding missing docs whenever I've worked on an API that requires them e.g. frame.isVisible.

@inancgumus
Copy link
Member Author

@ankur22

I think it's worth also adding the tap docs for the touchscreen class. I've been adding missing docs whenever I've worked on an API that requires them e.g. frame.isVisible.

👍 I thought about this, but to keep the PR focused, I preferred to update only the existing documentation for sync to async for Tap. I've added this as a task in the issue, and we can do it in the next PR.

@inancgumus inancgumus requested a review from ankur22 April 25, 2024 08:46
@inancgumus inancgumus merged commit 8d31bc1 into main-browser-async Apr 25, 2024
2 checks passed
@inancgumus inancgumus deleted the browser/async-tap branch April 25, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants