Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a better error message when Chromium isn't installed #1136

Closed
4 tasks done
inancgumus opened this issue Dec 13, 2023 · 0 comments
Closed
4 tasks done

Provide a better error message when Chromium isn't installed #1136

inancgumus opened this issue Dec 13, 2023 · 0 comments
Assignees
Labels

Comments

@inancgumus
Copy link
Member

inancgumus commented Dec 13, 2023

What?

Provide a new error message telling users to install Chromium to run browser tests on their system.

Why?

When users don't provide an executable path, or we can't find one, we say: "exec: no command", which can confuse most users (including me!). For instance, the following error says: "no command at browserFunction", which is hard to guess what's happening.

error building browser on IterStart: launching browser: exec: no command at browserFunction (file:///github/workspace/test.js:28:7(0))

Instead, we can say:

error building browser on IterStart: launching browser: chromium is not installed on this system at browserFunction (file:///github/workspace/test.js:28:7(0))

Tasks

Tasks

Preview Give feedback
  1. ux
    inancgumus
  2. inancgumus
  3. inancgumus
  4. area: browser
    inancgumus

Related PR(s)/Issue(s)

https://community.grafana.com/t/k6-browser-github-action-error-building-browser-no-command/109937

@inancgumus inancgumus added the ux label Dec 13, 2023
@inancgumus inancgumus self-assigned this Dec 13, 2023
inancgumus added a commit to grafana/k6 that referenced this issue Jan 12, 2024
Keeping the expected error message to contain a minimal part of the
error so that if we change the error again, this test won't bail.

Related: grafana/xk6-browser#1136
mstoykov pushed a commit to grafana/k6 that referenced this issue Jan 12, 2024
Keeping the expected error message to contain a minimal part of the
error so that if we change the error again, this test won't bail.

Related: grafana/xk6-browser#1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant