Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: Update release notes for chrome not installed errors #3516

Merged

Conversation

inancgumus
Copy link
Member

What?

Updates v0.49.0 release notes for the PRs: grafana/xk6-browser#1137 and grafana/xk6-browser#1145.

Why?

Provides better error messages when Chromium/Chrome isn't found.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/xk6-browser#1136

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-v0.49.0@37e10ba). Click here to learn what that means.

❗ Current head 183545d differs from pull request most recent head f8d4609. Consider uploading reports for the commit f8d4609 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.49.0    #3516   +/-   ##
==================================================
  Coverage                   ?   73.19%           
==================================================
  Files                      ?      267           
  Lines                      ?    20076           
  Branches                   ?        0           
==================================================
  Hits                       ?    14695           
  Misses                     ?     4467           
  Partials                   ?      914           
Flag Coverage Δ
ubuntu 73.14% <0.00%> (?)
windows 73.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inancgumus inancgumus changed the title Add/browser update chrome not installed errs Browser: Update release notes for chrome not installed errors Dec 21, 2023
@inancgumus inancgumus force-pushed the add/browser-update-chrome-not-installed-errs branch from b1b4957 to f8d4609 Compare December 21, 2023 10:20
@inancgumus inancgumus marked this pull request as ready for review January 8, 2024 09:15
@inancgumus inancgumus requested a review from ankur22 January 8, 2024 09:15
@github-actions github-actions bot requested a review from codebien January 8, 2024 09:15
@inancgumus inancgumus requested a review from ka3de January 8, 2024 09:15
@github-actions github-actions bot requested a review from joanlopez January 8, 2024 09:15
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inancgumus inancgumus merged commit 9a0db12 into release-v0.49.0 Jan 8, 2024
22 checks passed
@inancgumus inancgumus deleted the add/browser-update-chrome-not-installed-errs branch January 8, 2024 11:17
@mstoykov mstoykov added this to the v0.49.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants