Fix browser not found err in TestBrowserPermissions #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the expected error message to contain a minimal part of the error so that if we change the error again, this test won't bail. Related: grafana/xk6-browser#1136
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
- Coverage 72.54% 72.52% -0.02%
==========================================
Files 280 280
Lines 20938 20938
==========================================
- Hits 15189 15186 -3
- Misses 4778 4781 +3
Partials 971 971
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inancgumus
requested review from
codebien and
joanlopez
and removed request for
a team
mstoykov
approved these changes
Jan 12, 2024
olegbespalov
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes
TestBrowserPermissionsfailure. Expects the fake command to be in the error message rather than looking for the entire message to be more resilient for future changes.Why?
We've changed the browser not found error message in grafana/xk6-browser#1136. So, this PR (#3537) that includes the new changes currently fails without this fix.
Checklist
make lint), and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
grafana/xk6-browser#1136