-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promote env variable to ProfilingEnabled option #3692
feat: promote env variable to ProfilingEnabled option #3692
Conversation
if _, ok := env["K6_PROFILING_ENABLED"]; ok { | ||
result.ProfilingEnabled = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test for this in the configuraiton consolidation tests as was previously requested in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, yes of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and thsi can aso be set by cli flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen a code - I have to check --profiling-enabled
and K6_PROFILING_ENABLED
together, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR 🙇
it's a pleasure for me! |
I can add documentation if nobody disagrees. |
Thank you @Bablzz 🙇 |
What?
Add env option K6_PROFILING_ENABLED to enable it in k6
Why?
Fix issue #3670
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)