Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote env variable to ProfilingEnabled option #3692

Merged
merged 2 commits into from
Apr 24, 2024
Merged

feat: promote env variable to ProfilingEnabled option #3692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b536925
feat: promote env variable to ProfilingEnabled option
Bablzz Apr 18, 2024
1684839
Add simple test to check two ways to set profiling
Bablzz Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,5 +177,8 @@ func getFlags(defaultFlags GlobalFlags, env map[string]string) GlobalFlags {
if _, ok := env["NO_COLOR"]; ok {
result.NoColor = true
}
if _, ok := env["K6_PROFILING_ENABLED"]; ok {
result.ProfilingEnabled = true
}
Comment on lines +180 to +182
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for this in the configuraiton consolidation tests as was previously requested in the issue.

Copy link
Contributor Author

@Bablzz Bablzz Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, yes of course

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and thsi can aso be set by cli flag

Copy link
Contributor Author

@Bablzz Bablzz Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen a code - I have to check --profiling-enabled and K6_PROFILING_ENABLED together, right?

return result
}
Loading