Add K6_PROFILING_ENABLED env in exist option --profiling-enabled #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mstoykov
approved these changes
Apr 25, 2024
mstoykov
requested changes
Apr 25, 2024
Comment on lines
913
to
915
| | Env | CLI | Code / Config file | Default | | ||
| | ---------------------- | --------------------- | ------------------ | ------------------------------------ | | ||
| | `K6_PROFILING_ENABLED` | `--profiling-enabled` | N/A | `http://localhost:6565/debug/pprof/` | |
There was a problem hiding this comment.
Suggested change
| | Env | CLI | Code / Config file | Default | | |
| | ---------------------- | --------------------- | ------------------ | ------------------------------------ | | |
| | `K6_PROFILING_ENABLED` | `--profiling-enabled` | N/A | `http://localhost:6565/debug/pprof/` | | |
| | Env | CLI | Code / Config file | Default | | |
| | --- | --------------------- | ------------------ | ------------------------------------ | | |
| | N/A | `--profiling-enabled` | N/A | `http://localhost:6565/debug/pprof/` | |
This actually shoudn't change as v0.50.0 would not support it as it is alredy released
There was a problem hiding this comment.
oh, yeah, agree. did it according readme.md. thanks!
Fix MR. use suggest Co-authored-by: Mihail Stoykov <[email protected]>
mstoykov
reviewed
Apr 29, 2024
mstoykov
reviewed
Apr 29, 2024
mstoykov
approved these changes
Apr 29, 2024
codebien
approved these changes
Apr 30, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add information K6_PROFILING_ENABLED in exist option
--profiling-enabledClose documentation-needed in grafana/k6#3692
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)