-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabling the extraction of a specific selection from an element #3519
feat: enabling the extraction of a specific selection from an element #3519
Conversation
b715a27
to
b36d3ec
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3519 +/- ##
==========================================
- Coverage 72.48% 72.47% -0.01%
==========================================
Files 276 278 +2
Lines 20842 20933 +91
==========================================
+ Hits 15108 15172 +64
- Misses 4771 4786 +15
- Partials 963 975 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b36d3ec
to
50d21c8
Compare
It looks generally good, despite of the minor suggestions I left. However, after reading the discussion on the issue, I am not super confident about whether or not we want to expose/add (all) these methods. So, adding Mihail as reviewer, cause I've seen he's been involved in the discussion and so might have some feedback/thoughts to share around that. Thanks! |
what do you think @mstoykov about @joanlopez comment above
|
I think The As we do not have currently a As such I feel like we should just go with the p.s. sorry I was away for the holidays and this then fell through the cracks 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I kind of would prefer if the test was with teh original example, but not a big problem as long as it works.
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
What?
This pull request introduces enhancements to the k6 HTML module, including the addition of the
Selection
function. Its is designed to improve HTML parsing and manipulation capabilities within k6:Selection
Method: Added to theElement
type, it facilitates operations on the HTML content represented within anElement
.issue: #2683
Why?
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)