-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document element selection - grafana/k6#3519 #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
heitortsergent,
codebien,
olegbespalov and
joanlopez
January 17, 2024 08:46
joanlopez
reviewed
Jan 17, 2024
docs/sources/next/javascript-api/k6-html/element/element-selection.md
Outdated
Show resolved
Hide resolved
I will squash the changes in the second commit after some 👍 |
olegbespalov
approved these changes
Jan 17, 2024
mstoykov
force-pushed
the
documentElementSelection
branch
from
January 17, 2024 09:31
c15e447
to
e5b02fb
Compare
codebien
approved these changes
Jan 17, 2024
joanlopez
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught a couple of small typos. Otherwise, it looks good!
docs/sources/next/javascript-api/k6-html/element/element-selection.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-html/element/element-selection.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-html/element/element-selection.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
…tion.md Co-authored-by: Heitor Tashiro Sergent <[email protected]>
heitortsergent
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Document grafana/k6#3519
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.Select one of these and delete the others:
If updating the documentation for the most recent release of k6:
docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.If updating the documentation for the next release of k6:
docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)