Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document element selection - grafana/k6#3519 #1479

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jan 16, 2024

What?

Document grafana/k6#3519

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Select one of these and delete the others:

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@mstoykov
Copy link
Contributor Author

I will squash the changes in the second commit after some 👍

@mstoykov mstoykov force-pushed the documentElementSelection branch from c15e447 to e5b02fb Compare January 17, 2024 09:31
@mstoykov mstoykov requested a review from joanlopez January 17, 2024 09:31
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I caught a couple of small typos. Otherwise, it looks good! :shipit:

mstoykov and others added 2 commits January 25, 2024 10:42
@mstoykov mstoykov merged commit 2f47ae0 into main Jan 26, 2024
6 checks passed
@mstoykov mstoykov deleted the documentElementSelection branch January 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants