-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser's page.on('console')
to release notes
#3353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting the release notes 👍 I've left a couple of suggestions, one of which will help me understand our style a bit more on naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 WDYT about linking to the k6 docs (like this one)? So, we can tell users they can see an example there.
Co-authored-by: Ankur <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-notes-v0.47.0 #3353 +/- ##
========================================================
Coverage ? 72.96%
========================================================
Files ? 261
Lines ? 20018
Branches ? 0
========================================================
Hits ? 14607
Misses ? 4484
Partials ? 927
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Renames it in order to replace the xk6-browser references to use the format browser#PR instead.
I'm always doubtful on linking to documentation in the release notes. In this case, what do you think about adding this sentence to the end of the current description (see the bold italic part):
We can also link the |
LGTM. Can you help me understand why you're always doubtful referring to the documentation? |
Nevermind, just that it's "confusing" to link docs that are not released yet, but in this case they will be released pretty much at the same time so all good. Changed in 2d9bbb1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What?
Adds an entry for browser module's
page.on('console')
feature tov0.47.0
release notes.Why?
page.on('console')
method is a new feature for the browser module's API that should be announced in the upcoming k6 release.Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
page.on
xk6-browser#1006page.on()
docs k6-docs#1308