Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConsoleMessage link in page.on release notes #3357

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Sep 27, 2023

What?

Fixes a typo in browser's page.on method release notes.

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Related: #3353

@ka3de ka3de requested review from inancgumus and ankur22 September 27, 2023 13:05
@ka3de ka3de self-assigned this Sep 27, 2023
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-notes-v0.47.0@a164603). Click here to learn what that means.

❗ Current head f9d00a9 differs from pull request most recent head ddd3e8a. Consider uploading reports for the commit ddd3e8a to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             release-notes-v0.47.0    #3357   +/-   ##
========================================================
  Coverage                         ?   72.89%           
========================================================
  Files                            ?      259           
  Lines                            ?    20013           
  Branches                         ?        0           
========================================================
  Hits                             ?    14588           
  Misses                           ?     4493           
  Partials                         ?      932           
Flag Coverage Δ
ubuntu 72.89% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ka3de ka3de merged commit 9772c96 into release-notes-v0.47.0 Sep 27, 2023
20 of 21 checks passed
@ka3de ka3de deleted the fix/browser-page-on-link branch September 27, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants