Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k6 browser page.on() docs #1308

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Aug 28, 2023

Adds documentation for k6 browser's page.on(event, handler) method and the associated ConsoleMessage class.

Related grafana/xk6-browser#835
Closes #1307

@ka3de ka3de self-assigned this Aug 28, 2023
@ka3de ka3de force-pushed the update/browser-page-on branch from b19c731 to e73510a Compare August 28, 2023 14:12
@ka3de ka3de marked this pull request as ready for review August 28, 2023 14:15
@ka3de ka3de requested review from inancgumus, ankur22 and mdcruz August 28, 2023 14:16
@ka3de ka3de changed the base branch from main to update/browser-v1.1.0 August 28, 2023 14:16
@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1308/merge

It will be deleted automatically in 30 days.

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Some minor suggestions to simplify, feel free to skip.

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt update of the docs 🙂

LGTM. I only left one suggestion to ponder over.

Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ka3de ka3de force-pushed the update/browser-page-on branch from 73ec98b to 65cc3b7 Compare August 31, 2023 06:59
@ka3de ka3de merged commit fc93351 into update/browser-v1.1.0 Aug 31, 2023
@ka3de ka3de deleted the update/browser-page-on branch August 31, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add k6 browser's page.on docs
5 participants