-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k6 browser page.on()
docs
#1308
Conversation
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/on.md
Outdated
Show resolved
Hide resolved
b19c731
to
e73510a
Compare
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1308/merge It will be deleted automatically in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits.
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/on.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/on.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Some minor suggestions to simplify, feel free to skip.
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/on.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the prompt update of the docs 🙂
LGTM. I only left one suggestion to ponder over.
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/on.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
73ec98b
to
65cc3b7
Compare
Adds documentation for k6 browser's
page.on(event, handler)
method and the associatedConsoleMessage
class.Related grafana/xk6-browser#835
Closes #1307