Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.23 #1105

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Update Go version to 1.23 #1105

merged 7 commits into from
Aug 27, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Aug 26, 2024

Just checking that no breaking changes are introduced in this version. The merge of this PR can be deferred after all the other PRs are merged, to avoid conflicts.

This PR also fixes some slog.Error invocations that were wrong. In Go 1.22 it caused some wrong-format output but in Go 1.23 they are treated as compile errors.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (74ba237) to head (3025daf).
Report is 4 commits behind head on main.

Files Patch % Lines
cmd/beyla/main.go 0.00% 4 Missing ⚠️
pkg/internal/ebpf/common/ringbuf.go 0.00% 4 Missing ⚠️
pkg/export/otel/traces.go 0.00% 2 Missing ⚠️
pkg/internal/discover/attacher_linux.go 0.00% 2 Missing ⚠️
pkg/export/debug/debug.go 0.00% 1 Missing ⚠️
pkg/export/otel/metrics_proc.go 0.00% 1 Missing ⚠️
pkg/internal/connector/prommgr.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
+ Coverage   81.91%   82.00%   +0.09%     
==========================================
  Files         140      140              
  Lines       11450    11514      +64     
==========================================
+ Hits         9379     9442      +63     
- Misses       1548     1550       +2     
+ Partials      523      522       -1     
Flag Coverage Δ
integration-test 57.35% <6.25%> (+0.57%) ⬆️
k8s-integration-test 59.13% <6.25%> (-0.05%) ⬇️
oats-test 37.07% <0.00%> (+0.03%) ⬆️
unittests 52.31% <6.25%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 667b3bc into grafana:main Aug 27, 2024
6 checks passed
@mariomac mariomac deleted the go-1.23 branch August 27, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants