Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compilation on Mac #1107

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fixing compilation on Mac #1107

merged 2 commits into from
Aug 27, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Aug 26, 2024

Won't really pass tests until we merge: #1105

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (667b3bc) to head (df48998).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         140      140           
  Lines       11514    11514           
=======================================
  Hits         9435     9435           
  Misses       1554     1554           
  Partials      525      525           
Flag Coverage Δ
integration-test 57.07% <100.00%> (+0.03%) ⬆️
k8s-integration-test 59.16% <100.00%> (+<0.01%) ⬆️
oats-test 37.08% <100.00%> (+0.01%) ⬆️
unittests 52.29% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac changed the title WIP: fixing compilation on Mac Fixing compilation on Mac Aug 27, 2024
@mariomac mariomac merged commit 218f156 into grafana:main Aug 27, 2024
6 checks passed
@mariomac mariomac deleted the fix-mac branch August 27, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants