-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect OTel instrumentations in applications #1101
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 73.63% 81.97% +8.34%
==========================================
Files 172 140 -32
Lines 13091 11514 -1577
==========================================
- Hits 9640 9439 -201
+ Misses 2901 1551 -1350
+ Partials 550 524 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Do you plan add docs about the new flag in this PR?
Yeah, I'll add docs on how to disable and what it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! IMHO those integration tests are a bit overkill for this feature, but if there are not causing much slowing down, should be alright!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
@@ -0,0 +1,24 @@ | |||
# Build the testserver binary | |||
# Docker command must be invoked from the projec root directory | |||
FROM golang:1.22 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is still tagged as WIP, perhaps switch this to 1.23 already given #1105 is also coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It anyway doesn't matter, as even if Beyla is compiled with 1.23, it should support components compiled in earlier versions.
With this PR we add support for automatically detecting OpenTelemetry traces and metrics instrumentation inside processes, to remove them from being monitored by Beyla.
General implementation details:
This feature is particularly useful when we monitor all applications in a cluster. If certain applications are instrumented with the OpenTelemetry SDKs, we'll avoid them from now.
Limitations:
Test plan:
TODO: