Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mandrel-java17-22.1.0.0-Final not working on windows when installed under a path containing spaces. #386

Closed
zakkak opened this issue Jun 7, 2022 · 4 comments
Closed

mandrel-java17-22.1.0.0-Final not working on windows when installed under a path containing spaces. #386

zakkak opened this issue Jun 7, 2022 · 4 comments
Assignees
@Karm
Labels
affects/21.3 affects/22.1 bug Something isn't working
Milestone
22.2.0.0-Final

Comments

@zakkak
Copy link
Collaborator

zakkak commented Jun 7, 2022

Description

$title

See quarkusio/quarkus#25927 for more details

Configuration:

  • OS: Windows 10
  • Architecture: AMD64
  • Mandrel version: 22.1.0.0-Final
  • JDK version: 17
@zakkak zakkak added bug Something isn't working os/windows Windows specific affects/22.1 labels Jun 7, 2022
@zakkak zakkak mentioned this issue Jun 7, 2022
Closed
@zakkak zakkak changed the title mandrel-java17-22.1.0.0-Final not working when installed under a path containing spaces. mandrel-java17-22.1.0.0-Final not working on windows when installed under a path containing spaces. Jun 7, 2022
@jerboaa
Copy link
Collaborator

jerboaa commented Jun 7, 2022

Graal VM CE ships with a native native-image launcher. Could be a source of difference. Either way, we should be able to catch this in the future with an integration test.

@Karm Karm self-assigned this Jun 8, 2022
@Karm
Copy link
Collaborator

Karm commented Jun 8, 2022

This occurred in the past already and was fixed, so this is a regression in what we do in the launcher. I had problems with it while doing graalvm/mandrel-packaging#71 way back in the day.
Why haven't we caught it:

  • tests run either in C:\tmp\ or
  • it gets installed in C:\Program_Files' as created by New-Item -ItemType SymbolicLink -path 'C:\Program_Files' -Target 'C:\Program Files' -Force 😞

Assigning to me to fix the launcher and to fix the test.

@Karm Karm mentioned this issue Jun 8, 2022
Closed
Karm added a commit to Karm/graal that referenced this issue Jun 9, 2022
@Karm
Enables native-image script (bash, cmd) to handle module path with sp…
0da6c35 
…aces

The prolem does not affect distributions that use native-image executable.

e.g. graalvm#386
@Karm
Copy link
Collaborator

Karm commented Jun 9, 2022

Will be fixed by oracle#4635

@Karm Karm mentioned this issue Jun 10, 2022
Merged
@zakkak zakkak added this to the 22.2.0.0-Final milestone Jun 14, 2022
@zakkak zakkak added affects/21.3 and removed os/windows Windows specific labels Jun 14, 2022
@zakkak
Copy link
Collaborator Author

zakkak commented Jun 22, 2022

The fix is now merged upstream and included in the upcoming 22.2 release, it will also be backported to 21.3.3.

@zakkak zakkak closed this as completed Jun 22, 2022
graalvmbot pushed a commit to oracle/graal that referenced this issue Jun 22, 2022
@Karm @aelmassa
Enables native-image script (bash, cmd) to handle module path with sp…
94f5f58 
…aces

The prolem does not affect distributions that use native-image executable.

e.g. graalvm#386

(cherry picked from commit 0da6c35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karm Karm

Labels
affects/21.3 affects/22.1 bug Something isn't working
Projects
None yet
Milestone
22.2.0.0-Final
Development

No branches or pull requests
3 participants
@jerboaa @Karm @zakkak