-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for building Mandrel on Windows #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
requested changes
Nov 3, 2020
Nice work @Karm 👍 |
zakkak
reviewed
Nov 3, 2020
galderz
requested changes
Nov 4, 2020
Karm
changed the title
[WIP] Adds support for building Mandrel on Windows
Adds support for building Mandrel on Windows
Nov 4, 2020
zakkak
requested changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @Karm please see a couple more comments.
- Windows support - zip archive support for both Linux and Windows Building on Winows ------------------ * Installed Visual Studio (C/C++ support) * Installed Python 2.7 and on PATH (de facto mx requirements) * Downloaded OpenJDK * git et co., e.g. from https://github.com/cmderdev/cmder/releases/download/v1.3.16/cmder.zip * Have on PATH: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build Then: ``` set PYTHONHTTPSVERIFY=0 vcvarsall.bat x86_amd64 set JAVA_HOME=C:\projects\openjdk-11.0.9_11\ set PATH=%JAVA_HOME%\bin;%PATH% set MAVEN_REPO=C:/projects/.m2 set MANDREL_REPO=C:/projects/graal/graal set MX_HOME=C:/projects/graal/mx set MANDREL_HOME=C:/projects/graal/mandrel-java11-windows-amd64-20.2-SNAPSHOT %JAVA_HOME%/bin/java -ea build.java --maven-local-repository %MAVEN_REPO% --mandrel-repo %MANDREL_REPO% --mx-home %MX_HOME% --mandrel-version 20.2-SNAPSHOT --mandrel-home %MANDREL_HOME% --archive-suffix zip --verbose ```
zakkak
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again @Karm
galderz
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Windows
Then:
Status
It works, it builds Quarkus app on Windows and Linux (i.e. Linux build is not broken) in a "clean room" env. I will be doing some additional work though:
static void checkMx()
method--force-bash-launchers=false
The overall picture is working and O.K. though....