Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-39065] Enables native-image script to handle module path with spaces. #4635

Merged

Conversation

Karm
Copy link
Contributor

@Karm Karm commented Jun 9, 2022

The problem does not affect distributions that use native-image executable.

Mandrel distribution uses native-image as a launcher script, bash on Linux, cmd on Windows and it suffers when installed in a path with spaces in it.

…aces

The prolem does not affect distributions that use native-image executable.

e.g. graalvm#386
@Karm
Copy link
Contributor Author

Karm commented Jun 9, 2022

Hello @ezzarghili, @gilles-duboscq,

I would like this patch to make it in for the upcoming 22.2 release, would it be possible?

Cheers
K.

@fniephaus
Copy link
Member

I would like this patch to make it in for the upcoming 22.2 release, would it be possible?

Yes. I'll take care of it.

@fniephaus fniephaus changed the title Enables native-image script to handle module path with spaces [GR-39065] Enables native-image script to handle module path with spaces. Jun 10, 2022
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fniephaus fniephaus added this to the 22.2 milestone Jun 10, 2022
@graalvmbot graalvmbot merged commit cbecf28 into oracle:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants