Add some logging to help determine which game server / namespace is causing this particular error

[roberthbailey]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[markmandel]

🚚

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Failed 😱

Build Id: 2428a1a5-7037-467f-9801-8de255577b86

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

That's a new flaky one:

{"groupKind":{"Group":"agones.dev","Kind":"GameServer"},"message":"Added webhook handler","op":"CREATE","path":"/validate","severity":"info","source":"*webhooks.WebHook","time":"2020-12-14T23:23:53.462214717Z"}
--- FAIL: TestControllerSyncGameServerRequestReadyState (0.70s)
    --- FAIL: TestControllerSyncGameServerRequestReadyState/GameServer_whose_pod_is_currently_not_in_a_running_state,_so_should_retry_and_not_update (0.11s)
        controller_test.go:1317: 
            	Error Trace:	controller_test.go:1317
            	Error:      	Error message not equal:
            	            	expected: "game server container is not currently running, try again"
            	            	actual  : "game server container for GameServer test in namespace default is not currently running, try again"
            	Test:       	TestControllerSyncGameServerRequestReadyState/GameServer_whose_pod_is_currently_not_in_a_running_state,_so_should_retry_and_not_update
{"message":"Wait for cache sync","severity":"info","time":"2020-12-14T23:23:53.496869656Z"}

[agones-bot]

Build Failed 😱

Build Id: 87edac71-9b38-43b4-9f48-a14578d86ae4

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

oh wait, that's not flaky - that's a legit unit test error :)

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[roberthbailey]

oh wait, that's not flaky - that's a legit unit test error :)

That's what I get for just pushing a change w/o running tests locally....

[agones-bot]

Build Failed 😱

Build Id: f9acd781-dbc2-4faf-851b-0fda3730be8e

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

This failure seems unrelated.

Unit tests look ok:

48 specs, 0 failures
Finished in 0.081 seconds

But site-static failed with:

Please install PostCSS 8 or above
Error: Error building site: POSTCSS: failed to transform "scss/main.css" (text/css): Please install PostCSS 8 or above
make[2]: *** [site-static] Error 255
make[2]: Entering directory '/workspace/build'
docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build --workdir=/go/src/agones.dev/agones/site  agones-build:8432895f39 rm -r ./public
includes/website.mk:35: recipe for target 'site-static' failed

[agones-bot]

Build Failed 😱

Build Id: e62e445f-831e-471a-a747-b43ced5a8b8f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Same error again...

[agones-bot]

Build Failed 😱

Build Id: fa28b324-ce5e-4a1b-9ed6-7580e760b6f7

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Can replicate locally when refreshing node_modules

che/go-build --workdir=/go/src/agones.dev/agones/site  agones-build:8432895f39 \
        bash -c "npm list postcss-cli || npm install postcss-cli"
/go/src/agones.dev/agones/site
`-- UNMET DEPENDENCY [email protected]

npm ERR! missing: [email protected], required by site
npm WARN deprecated [email protected]: Please update to v 2.2.x

Will dig in and work out a fix 👍

[roberthbailey]

Thanks Mark! (it seems like this is going to cause issues with the RC anyway)

[markmandel]

Should be fixed in #1930 - just waiting for it to pass.

[roberthbailey]

Rebased on #1930 and re-pushed.

[agones-bot]

Build Succeeded 👏

Build Id: 469390cd-e684-4787-aa63-e435bfeae748

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.11.0-e20e435
• image: gcr.io/agones-images/agones-sdk:1.11.0-e20e435
• image: gcr.io/agones-images/agones-ping:1.11.0-e20e435
• Linux C++ SDK (build): agonessdk-1.11.0-e20e435-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.11.0-e20e435.zip

A preview of the website (the last 30 builds are retained):

• https://e20e435-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1929/head:pr_1929 && git checkout pr_1929
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-e20e435