Skip to content

Commit

Permalink
Add some logging to help determine which game server / namespace is
Browse files Browse the repository at this point in the history
causing this particular error.
  • Loading branch information
roberthbailey committed Dec 15, 2020
1 parent 0c3bb3a commit e20e435
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/gameservers/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ func (c *Controller) syncGameServerRequestReadyState(gs *agonesv1.GameServer) (*
// check to make sure this container is actually running. If there was a recent crash, the cache may
// not yet have the newer, running container.
if cs.State.Running == nil {
return nil, errors.New("game server container is not currently running, try again")
return nil, fmt.Errorf("game server container for GameServer %s in namespace %s is not currently running, try again", gsCopy.ObjectMeta.Name, gsCopy.ObjectMeta.Namespace)
}
gsCopy.ObjectMeta.Annotations[agonesv1.GameServerReadyContainerIDAnnotation] = cs.ContainerID
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/gameservers/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,7 @@ func TestControllerSyncGameServerRequestReadyState(t *testing.T) {
defer cancel()

_, err = c.syncGameServerRequestReadyState(gsFixture)
assert.EqualError(t, err, "game server container is not currently running, try again")
assert.EqualError(t, err, "game server container for GameServer test in namespace default is not currently running, try again")
assert.False(t, gsUpdated, "GameServer was updated")
})

Expand Down

0 comments on commit e20e435

Please sign in to comment.