New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update table.create to not reset id #700

Merged

steffnay merged 1 commit into googleapis:main from steffnay:self-id-fix

Oct 22, 2021

Contributor

steffnay commented Oct 8, 2021 •

edited

Loading

Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

🦕


          fix: update table.create to not reset id

d94e895

steffnay requested a review from a team as a code owner

October 8, 2021 21:22

google-cla bot added the cla: yes label

steffnay added the owlbot:run label

steffnay requested a review from shaffeeullah

October 8, 2021 21:57

gcf-owl-bot bot removed the owlbot:run label

shaffeeullah approved these changes

View reviewed changes

Contributor

shaffeeullah commented Oct 8, 2021

Note: This PR reverts the changes created by #696 .
nodejs-bigquery relies on self.id because metadata.id has the project ID prepended.

bcoe approved these changes

View reviewed changes

steffnay merged commit b1ceb53 into googleapis:main

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 3.8.0 (#705)

d561655

🤖 I have created a release \*beep\* \*boop\*
---
## [3.8.0](https://www.github.com/googleapis/nodejs-common/compare/v3.7.3...v3.8.0) (2021-11-01)


### Features

* Add retry support for 504 (Gateway Timeout) ([#704](https://www.github.com/googleapis/nodejs-common/issues/704)) ([5a3a96f](https://www.github.com/googleapis/nodejs-common/commit/5a3a96f5aa607e53d71e7ed9af5f26431af45679))


### Bug Fixes

* allow authentication with custom endpoint ([#698](https://www.github.com/googleapis/nodejs-common/issues/698)) ([4c0f7ec](https://www.github.com/googleapis/nodejs-common/commit/4c0f7ec0c6ebedc34eaaab79fc053e7e889e243d))
* update table.create to not reset id ([#700](https://www.github.com/googleapis/nodejs-common/issues/700)) ([b1ceb53](https://www.github.com/googleapis/nodejs-common/commit/b1ceb532ac7bf4852f430c83af5a71618ed42f54))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels