feat: Add retry support for 504 (Gateway Timeout) #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a downstream issue googleapis/nodejs-storage#1635 by adding support for gateway timeouts - which is also compliant with https://cloud.google.com/storage/docs/retry-strategy#idempotency-operations
google-cla
bot
added
the
cla: yes
danielbankhead
added
the
do not merge
|
Added |
JustinBeckwith
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
From a breaking change perspective, I think this is fine and won't harm anything. From a practical standpoint though, we need to make 100% sure GCS isn't the cause of these responses. It's very likely a users upstream proxy causing the problem, and there's only so much dancing around that we can really do.
danielbankhead
removed
the
do not merge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-common/compare/v3.7.3...v3.8.0) (2021-11-01) ### Features * Add retry support for 504 (Gateway Timeout) ([#704](https://www.github.com/googleapis/nodejs-common/issues/704)) ([5a3a96f](https://www.github.com/googleapis/nodejs-common/commit/5a3a96f5aa607e53d71e7ed9af5f26431af45679)) ### Bug Fixes * allow authentication with custom endpoint ([#698](https://www.github.com/googleapis/nodejs-common/issues/698)) ([4c0f7ec](https://www.github.com/googleapis/nodejs-common/commit/4c0f7ec0c6ebedc34eaaab79fc053e7e889e243d)) * update table.create to not reset id ([#700](https://www.github.com/googleapis/nodejs-common/issues/700)) ([b1ceb53](https://www.github.com/googleapis/nodejs-common/commit/b1ceb532ac7bf4852f430c83af5a71618ed42f54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a downstream issue googleapis/nodejs-storage#1635 by adding support for gateway timeouts - which is also compliant with https://cloud.google.com/storage/docs/retry-strategy#idempotency-operations
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis/nodejs-storage#1635 🦕