Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated instance id to match returned metadata id #696

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

shaffeeullah
Copy link
Contributor

Fixes bug where deleting, getting, and getting metadata for notifications in nodejs-storage would always 404 (because it was looking for the wrong id)

@shaffeeullah shaffeeullah requested a review from a team as a code owner October 6, 2021 19:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@danielbankhead danielbankhead merged commit f15b02d into main Oct 6, 2021
@danielbankhead danielbankhead deleted the shaffeeullah/updateInstanceId branch October 6, 2021 20:18
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 6, 2021
@danielduhh
Copy link

Is there an issue for this? @shaffeeullah

@shaffeeullah
Copy link
Contributor Author

no

Is there an issue for this? @shaffeeullah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants