Unmark most of the xfailed tests. #5421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
added
the
do not merge
|
Hmm, I ran the system tests I un-marked individually, and they all passed, but they fail on CI (and for me locally, now that I look at it) when running the who system test suite. |
tseaver
force-pushed
the
bigtable-un_xfail_systests_after_5398
branch
from
1c730f4
to
1cbdcda
Compare
|
The source of the failures when running all system tests was re-using table names across tests: apparently, a deleted table now "sticks around" a while, and cannot be re-created without risking timeout / deadline exceeded. 1cbdcda ensures that the tests no longer try to re-created a table (by using unique names). |
tseaver
removed
the
do not merge
|
@theacodes This is the same #5441 / #5442 issue. I'd like to merge here as well based on the CircleCI green. |
theacodes
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by PR #5398.