Skip to content

Commit

Permalink
Unmark most of the xfailed tests.
Browse files Browse the repository at this point in the history
Fixed by PR #5398.
  • Loading branch information
tseaver committed May 31, 2018
1 parent 5a79d5d commit 1c730f4
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions bigtable/tests/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,16 +226,12 @@ def tearDown(self):
for table in self.tables_to_delete:
table.delete()

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_list_tables(self):
# Since `Config.INSTANCE` is newly created in `setUpModule`, the table
# created in `setUpClass` here will be the only one.
tables = Config.INSTANCE.list_tables()
self.assertEqual(tables, [self._table])

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_create_table(self):
temp_table_id = 'foo-bar-baz-table'
temp_table = Config.INSTANCE.table(temp_table_id)
Expand All @@ -252,8 +248,6 @@ def test_create_table(self):
sorted_tables = sorted(tables, key=name_attr)
self.assertEqual(sorted_tables, expected_tables)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_create_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table = Config.INSTANCE.table(temp_table_id)
Expand All @@ -275,8 +269,6 @@ def test_create_column_family(self):
column_family.column_family_id)
self.assertEqual(retrieved_col_fam.gc_rule, gc_rule)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_update_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table = Config.INSTANCE.table(temp_table_id)
Expand All @@ -300,8 +292,6 @@ def test_update_column_family(self):
col_fams = temp_table.list_column_families()
self.assertIsNone(col_fams[COLUMN_FAMILY_ID1].gc_rule)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_delete_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table = Config.INSTANCE.table(temp_table_id)
Expand Down Expand Up @@ -385,8 +375,6 @@ def _write_to_row(self, row1=None, row2=None, row3=None, row4=None):
cell4 = Cell(CELL_VAL4, timestamp4_micros)
return cell1, cell2, cell3, cell4

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_timestamp_filter_millisecond_granularity(self):
from google.cloud.bigtable import row_filters

Expand All @@ -397,8 +385,6 @@ def test_timestamp_filter_millisecond_granularity(self):
row_data = self._table.read_rows(filter_=timefilter)
row_data.consume_all()

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_mutate_rows(self):
row1 = self._table.row(ROW_KEY)
row1.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, CELL_VAL1)
Expand Down Expand Up @@ -426,8 +412,6 @@ def test_mutate_rows(self):
self.assertEqual(
row2_data.cells[COLUMN_FAMILY_ID1][COL_NAME1][0].value, CELL_VAL4)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_large_cell_limit(self):
row = self._table.row(ROW_KEY)
self.rows_to_delete.append(row)
Expand All @@ -445,8 +429,6 @@ def test_read_large_cell_limit(self):
self.assertEqual(len(column), 1)
self.assertEqual(column[0].value, data)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_row(self):
row = self._table.row(ROW_KEY)
self.rows_to_delete.append(row)
Expand All @@ -471,8 +453,6 @@ def test_read_row(self):
}
self.assertEqual(partial_row_data.cells, expected_row_contents)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_rows(self):
row = self._table.row(ROW_KEY)
row_alt = self._table.row(ROW_KEY_ALT)
Expand Down Expand Up @@ -518,8 +498,6 @@ def test_read_rows(self):
}
self.assertEqual(rows_data.rows, expected_rows)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_with_label_applied(self):
self._maybe_emulator_skip('Labels not supported by Bigtable emulator')
row = self._table.row(ROW_KEY)
Expand Down

0 comments on commit 1c730f4

Please sign in to comment.