Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmark most of the xfailed tests. #5421

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Unmark most of the xfailed tests. #5421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0366a2d
Unmark most of the xfailed tests.
tseaver May 31, 2018
1cbdcda
Avoid reusing temp table names across tests.
tseaver May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 5 additions & 25 deletions bigtable/tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,18 +226,14 @@ def tearDown(self):
for table in self.tables_to_delete:
table.delete()

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_list_tables(self):
# Since `Config.INSTANCE` is newly created in `setUpModule`, the table
# created in `setUpClass` here will be the only one.
tables = Config.INSTANCE.list_tables()
self.assertEqual(tables, [self._table])

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_create_table(self):
temp_table_id = 'foo-bar-baz-table'
temp_table_id = 'test-create-table'
temp_table = Config.INSTANCE.table(temp_table_id)
temp_table.create()
self.tables_to_delete.append(temp_table)
Expand All @@ -252,10 +248,8 @@ def test_create_table(self):
sorted_tables = sorted(tables, key=name_attr)
self.assertEqual(sorted_tables, expected_tables)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_create_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table_id = 'test-create-column-family'
temp_table = Config.INSTANCE.table(temp_table_id)
temp_table.create()
self.tables_to_delete.append(temp_table)
Expand All @@ -275,10 +269,8 @@ def test_create_column_family(self):
column_family.column_family_id)
self.assertEqual(retrieved_col_fam.gc_rule, gc_rule)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_update_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table_id = 'test-update-column-family'
temp_table = Config.INSTANCE.table(temp_table_id)
temp_table.create()
self.tables_to_delete.append(temp_table)
Expand All @@ -300,10 +292,8 @@ def test_update_column_family(self):
col_fams = temp_table.list_column_families()
self.assertIsNone(col_fams[COLUMN_FAMILY_ID1].gc_rule)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_delete_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table_id = 'test-delete-column-family'
temp_table = Config.INSTANCE.table(temp_table_id)
temp_table.create()
self.tables_to_delete.append(temp_table)
Expand All @@ -325,7 +315,7 @@ class TestDataAPI(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls._table = table = Config.INSTANCE.table(TABLE_ID)
cls._table = table = Config.INSTANCE.table('test-data-api')
table.create()
table.column_family(COLUMN_FAMILY_ID1).create()
table.column_family(COLUMN_FAMILY_ID2).create()
Expand Down Expand Up @@ -385,8 +375,6 @@ def _write_to_row(self, row1=None, row2=None, row3=None, row4=None):
cell4 = Cell(CELL_VAL4, timestamp4_micros)
return cell1, cell2, cell3, cell4

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_timestamp_filter_millisecond_granularity(self):
from google.cloud.bigtable import row_filters

Expand All @@ -397,8 +385,6 @@ def test_timestamp_filter_millisecond_granularity(self):
row_data = self._table.read_rows(filter_=timefilter)
row_data.consume_all()

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_mutate_rows(self):
row1 = self._table.row(ROW_KEY)
row1.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, CELL_VAL1)
Expand Down Expand Up @@ -445,8 +431,6 @@ def test_read_large_cell_limit(self):
self.assertEqual(len(column), 1)
self.assertEqual(column[0].value, data)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_row(self):
row = self._table.row(ROW_KEY)
self.rows_to_delete.append(row)
Expand All @@ -471,8 +455,6 @@ def test_read_row(self):
}
self.assertEqual(partial_row_data.cells, expected_row_contents)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_rows(self):
row = self._table.row(ROW_KEY)
row_alt = self._table.row(ROW_KEY_ALT)
Expand Down Expand Up @@ -518,8 +500,6 @@ def test_read_rows(self):
}
self.assertEqual(rows_data.rows, expected_rows)

@pytest.mark.xfail(reason="https://github.com/GoogleCloudPlatform/"
"google-cloud-python/issues/5362")
def test_read_with_label_applied(self):
self._maybe_emulator_skip('Labels not supported by Bigtable emulator')
row = self._table.row(ROW_KEY)
Expand Down