-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched to google-resumable-media in BigQuery. #3555
Switched to google-resumable-media in BigQuery. #3555
Conversation
a97c930
to
aa7999f
Compare
cc51bc0
to
2c45d9b
Compare
OK after some work last night by @jonparrott and by me this AM, the unit tests are passing at 100%. I'm fairly certain there will be a system test breakage though. I seem to recall the getting the |
2c45d9b
to
2ae7cf3
Compare
w00t! I confirmed the system tests pass locally:
|
OK CircleCI is green. Let's merge?!? |
* Switched to google-resumable-media in BigQuery. * Upgrading google-resumable-media dependency to 0.2.1.
* Switched to google-resumable-media in BigQuery. * Upgrading google-resumable-media dependency to 0.2.1.
* Switched to google-resumable-media in BigQuery. * Upgrading google-resumable-media dependency to 0.2.1.
@jonparrott Asked that I make a "do not merge" PR out of this, as a placeholder for the work remaining in #1998.
When I wrote this code (May 10th), the system tests all passed without issue (THAT WAS NOT TRUE WHEN I WROTE IT), but the unit tests are currently very broken by this change.
I am very much intentionally leaving the "Allow edits from maintainers" box checked, so anyone is free to fix the unit tests 😀