Tear httplib2 out of google-cloud

[dhermes]

I plan to tackle this soon-ish.

This is so we can move to a better-maintained (or allow BYO) transport layer.

[theacodes]

This should now be possible since oauth2client has been replaced with google-auth.

[dhermes]

google.cloud.streaming needs fixin' first (I seem to recall @jonparrott volunteering for that one, but can't confirm it because our chat history gets deleted!)

[theacodes]

Have we a bug for streaming?

My chat history gets deleted to prevent me from volunteering for dumb things.

[dhermes]

I don't think so, it's part of the "ditch httplib2 bug"

[daspecster]

@dhermes @jonparrott is google_auth_httplib2.py what should be used instead of directly using httplib2?

[theacodes]

That's already the case. We should stop using httplib2 completely and switch to urllib3.

…

On Tue, Mar 7, 2017, 7:40 AM Thomas Schultz ***@***.***> wrote: @dhermes <https://github.com/dhermes> @jonparrott <https://github.com/jonparrott> is google_auth_httplib2.py <https://github.com/GoogleCloudPlatform/google-auth-library-python/blob/master/httplib2_transport/google_auth_httplib2.py> what should be used instead of directly using httplib2? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1998 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc4JemYIoNQ_HoPy7KSbmgZqI-xJeks5rjXplgaJpZM4JQDt8> .

[dhermes]

Here is what remains:

• Stop using google.cloud.streaming in BigQuery. I've already done this in the source, but don't have the bandwidth to update the unit/system tests Switched to google-resumable-media in BigQuery. #3555
• Delete google.cloud.streaming from google-cloud-core Removing vendored in google.cloud.streaming. #3654
• Change the default http object to a requests object Remove httplib2, replace with Requests #3674
• Deal with the fall out of the previous change (i.e. broken tests and broken code paths) Remove httplib2, replace with Requests #3674
• Do a git grep for httplib2 and get rid of all of it Remove httplib2, replace with Requests #3674

[bmabey]

@dhermes Do you have a timeline for when this will be completed?

[dhermes]

@bmabey Much closer right now (because #3555 is done, w00t!) then we were 24 days ago.

[theacodes]

I am bumping this to a p1 and assigning to myself, it's critical that we remove usage of httplib2 before we GA any more libraries.

[theacodes]

/cc @lukesneeringer on that last comment.

[lukesneeringer]

Copy that. Thank you for the effort.

[lukesneeringer]

Note: Translate is NOT pushed to PyPI yet; do I need to hold it?

[theacodes]

@lukesneeringer translate is probably okay. All of the other current GA libraries accept an http parameter that has to be an httplib2 instance, so I'm not sure how we want to deal with that yet.

Update: nvm, the _http parameter to client constructors is and has always been private and explicitly documented that we reserve the right to change it. I'm sure there are a handful of users out there specifying it, but they can pin versions until they're ready to switch.

[dhermes]

Ahhhhhhh! 🙌 🎊 🥇 🎉 🌮

[tseaver]

GOOOOOOOOOOOOOOOOOOOOOAL!!!

[daspecster]

Congrats guys!