Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify AnnotateImageRequest items in single-feature methods. #3554

Merged
merged 2 commits into from
Jun 27, 2017

Conversation

lukesneeringer
Copy link
Contributor

This commit makes it such that any other part of an AnnotateImageRequest can be specified on the single-feature methods as a keyword argument. Needed for crop hints.

@lukesneeringer lukesneeringer self-assigned this Jun 27, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -55,15 +55,21 @@ class SingleFeatureMethodTests(unittest.TestCase):
def test_runs_generic_single_image(self, ai):
ai.return_value = vision.types.AnnotateImageResponse()

# Prove that other aspects of the AnnotateImageRequest, such as the
# image context, will be preserved.
SENTINEL = object()

This comment was marked as spam.

@tseaver tseaver added the api: vision Issues related to the Cloud Vision API. label Jun 27, 2017
@lukesneeringer lukesneeringer merged commit 8ab1afe into googleapis:master Jun 27, 2017
@lukesneeringer lukesneeringer deleted the vision-image-context branch June 27, 2017 19:19
tseaver pushed a commit that referenced this pull request Jul 10, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants