-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to specify AnnotateImageRequest items in single-feature methods. #3554
Merged
lukesneeringer
merged 2 commits into
googleapis:master
from
lukesneeringer:vision-image-context
Jun 27, 2017
Merged
Add the ability to specify AnnotateImageRequest items in single-feature methods. #3554
lukesneeringer
merged 2 commits into
googleapis:master
from
lukesneeringer:vision-image-context
Jun 27, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 27, 2017
dhermes
approved these changes
Jun 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -55,15 +55,21 @@ class SingleFeatureMethodTests(unittest.TestCase): | |||
def test_runs_generic_single_image(self, ai): | |||
ai.return_value = vision.types.AnnotateImageResponse() | |||
|
|||
# Prove that other aspects of the AnnotateImageRequest, such as the | |||
# image context, will be preserved. | |||
SENTINEL = object() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
pushed a commit
that referenced
this pull request
Jul 10, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: vision
Issues related to the Cloud Vision API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it such that any other part of an
AnnotateImageRequest
can be specified on the single-feature methods as a keyword argument. Needed for crop hints.