Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: support features blacklisted in conformance tests #6533

Closed
6 tasks done
tseaver opened this issue Nov 15, 2018 · 1 comment
Closed
6 tasks done

Firestore: support features blacklisted in conformance tests #6533

tseaver opened this issue Nov 15, 2018 · 1 comment
Assignees
Labels
api: firestore Issues related to the Firestore API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 15, 2018

PR #6290 blacklisted a number of conformance tests because we do not currently support the usecases they support:

  • get-* tests (because we use BatchGetDocuments API rather than the GetDocument API.
  • listen-* tests exercise the "watch" features (since landed in PR Firestore: add Watch Support #6191).
  • update_paths-* tests (they've been excluded forever, with a note that Python lacked the support).
  • Tests involving unimplemented / incorrectly implemented "transforms" (DELETE, ARRAY_REMOVE, ARRAY_UNION).
  • query-* tests have been (inadvertently) skipped since being copied in from google-cloud-common in PR Re-sync with .proto / .textproto files from google-cloud-common. #5351).

This is a tracking issue for removing those skips / blacklist entries:

Not in scope:

- Figure how to support the "update with paths" use case, and enable those tests.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 22, 2018

Note: by my read of the spec document, we do not need to support the update-paths-* cases: they are for an alternative spelling of Document.update in languages which cannot use objects (such as FieldPath instances) as map keys.

tseaver added a commit that referenced this issue Nov 27, 2018
Update conformance test to actually run for 'get'.

Toward #6533.
mcdonc added a commit to mcdonc/google-cloud-python that referenced this issue Dec 17, 2018
tseaver pushed a commit that referenced this issue Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants