Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: add driver for query conformance tests. #6839

Merged
merged 5 commits into from
Dec 12, 2018
Merged

Firestore: add driver for query conformance tests. #6839

merged 5 commits into from
Dec 12, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 4, 2018

Uses #6837 as a base: please review that PR first.

Toward #6533.

Fix confusion (from #6829) between __name__ fields as simple strings and as DocumentReference instances.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Dec 4, 2018
@tseaver tseaver requested a review from crwilcox December 4, 2018 16:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2018
@tseaver tseaver added the testing label Dec 4, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Dec 12, 2018

Rebased after merging #6837.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Dec 12, 2018

No invocation log available for the failed Kokoro Firestore build. All tests pass when run locally.

@tseaver tseaver merged commit 35bc2ba into googleapis:master Dec 12, 2018
@tseaver tseaver deleted the 6533-firestore-query_conformance_tests branch December 12, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants