Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Query start/end at/after accepts snapshots, doesn't properly apply implicit ordering. #6555

Closed
crwilcox opened this issue Nov 16, 2018 · 2 comments
Closed

[Firestore] Query start/end at/after accepts snapshots, doesn't properly apply implicit ordering. #6555

crwilcox opened this issue Nov 16, 2018 · 2 comments
Assignees
@tseaver
Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Nov 16, 2018 •
edited
Loading

Query.start_at()/start_after()/end_at()/end_after() accepts DocumentSnapshots, but doesn’t properly apply the implicit ordering.
@crwilcox crwilcox added api: firestore Issues related to the Firestore API. triaged for GA labels Nov 16, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

We have conformance tests for this one, but as I noted in #6533, we don't actually run them (and never have).

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 17, 2018
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Nov 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Nov 19, 2018
@crwilcox crwilcox mentioned this issue Nov 27, 2018
Closed
@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2018

Actual semantics are documented in #6665, including links to the conformance tests. Closing this one in its favor.

@tseaver tseaver closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @JustinBeckwith @crwilcox