Introduce remaining BigQuery to GA items #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
added
the
do not merge
|
I think this is a definite improvement from a usability standpoint. nice job so far! |
|
Looks like a really good change @dwsupplee ! |
|
Thanks for the feedback, it's greatly appreciated :) |
|
/cc @ElliottBrossard, @tswast This should be ready to review! For the remainder of our upcoming changes please see #644. |
dwsupplee
removed
the
do not merge
dwsupplee
changed the title
dwsupplee
force-pushed
the
job-config
branch
from
73abfa3 to
0ecb69e
Compare
dwsupplee
force-pushed
the
job-config
branch
from
0ecb69e to
59dc30f
Compare
dwsupplee
added a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Oct 16, 2017
* introduce job configuration classes * update tests/docs and add copy/load * modify retry logic * add create on insert logic
dwsupplee
added a commit
that referenced
this pull request
Oct 16, 2017
* Run query and wait for it to complete (#604) * Run query and wait for it to complete * Document exception on BigQueryClient::runQuery() * Update snippet test * Add support for etags on bigquery tables and datasets (#634) * [BC Break] Switch to standard SQL by default (#640) * Switch to standard SQL by default * Fix setting of useLegacySql option * Fix job config logic * Address code review * [BC Break] Implement waitUntilComplete and block while waiting for query results (#642) * implement waitUntilComplete on job and block waiting for queryResults * fix getIterator docblock * Generate BigQuery Job ID on client side with optional prefix (#643) * address code review * Introduce remaining BigQuery to GA items (#686) * introduce job configuration classes * update tests/docs and add copy/load * modify retry logic * add create on insert logic
This was referenced Oct 16, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #354, #622
The following items are included in this PR:
I hope! Would love some feedback on this before finishing up the rest of the tests/docs)./cc @bencromwell Given the issue found before with the way jobs were configured, your feedback on this item would be really wonderful :).
Todos (based on feedback):
Update testsUpdate docsAdd load/copy job configuration classes